functionapp: handle .funcignore more gracefully#7223
Open
weikanglim wants to merge 3 commits intoAzure:mainfrom
Open
functionapp: handle .funcignore more gracefully#7223weikanglim wants to merge 3 commits intoAzure:mainfrom
weikanglim wants to merge 3 commits intoAzure:mainfrom
Conversation
weikanglim
changed the title
weikanglim
force-pushed
the
weilim/js-func-local-build-switch
branch
from
95678ea to
130bdb7
Compare
weikanglim
requested review from
JeffreyCA,
hemarina,
rajeshkamal5050,
tg-msft and
vhvb1989
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Azure Function App deployments to choose remoteBuild more intelligently for flex-consumption plans by inspecting .funcignore, and to fail fast when an explicitly configured remoteBuild conflicts with .funcignore contents.
Changes:
- Add
resolveFunctionAppRemoteBuildto infer/validateremoteBuildbased on.funcignore(especiallynode_modules). - Update flex-consumption deployment path to use the new resolver and provide actionable suggestions on failure.
- Add unit tests covering JavaScript remote build decision matrix and non-JavaScript defaults.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
cli/azd/pkg/project/service_target_functionapp.go |
Introduces resolveFunctionAppRemoteBuild and wires it into flex-consumption deployments with suggestion-backed errors. |
cli/azd/pkg/project/service_target_functionapp_test.go |
Adds tests validating remote build inference/validation and language-based defaults. |
| }, | ||
| { | ||
| name: "RemoteBuildFalseAndFuncIgnoreExcludesNodeModules_Errors", | ||
| remoteBuild: new(false), |
There was a problem hiding this comment.
new(false) / new(true) is not valid Go (the built-in new takes a type, not a value). This will not compile. Replace these with a helper (e.g., boolPtr(false)), or assign to a local b := false and take &b.
| }, | ||
| { | ||
| name: "RemoteBuildTrueAndFuncIgnoreExcludesNodeModules_Succeeds", | ||
| remoteBuild: new(true), |
There was a problem hiding this comment.
new(false) / new(true) is not valid Go (the built-in new takes a type, not a value). This will not compile. Replace these with a helper (e.g., boolPtr(false)), or assign to a local b := false and take &b.
| }, | ||
| { | ||
| name: "RemoteBuildTrueAndFuncIgnoreDoesNotExcludeNodeModules_Errors", | ||
| remoteBuild: new(true), |
There was a problem hiding this comment.
new(false) / new(true) is not valid Go (the built-in new takes a type, not a value). This will not compile. Replace these with a helper (e.g., boolPtr(false)), or assign to a local b := false and take &b.
| require.NoError(t, err) | ||
| require.True(t, remoteBuild) | ||
|
|
||
| pythonConfig.RemoteBuild = new(false) |
There was a problem hiding this comment.
new(false) / new(true) is not valid Go (the built-in new takes a type, not a value). This will not compile. Replace these with a helper (e.g., boolPtr(false)), or assign to a local b := false and take &b.
Suggested change
| pythonConfig.RemoteBuild = new(false) | |
| b := false | |
| pythonConfig.RemoteBuild = &b |
| } | ||
|
|
||
| if *serviceConfig.RemoteBuild && !nodeModulesExcluded { | ||
| return false, &internal.ErrorWithSuggestion{ |
There was a problem hiding this comment.
internal.ErrorWithSuggestion is referenced but internal is not imported in this file’s import block (based on the shown diff). This will fail to compile; add the appropriate github.com/azure/azure-dev/cli/azd/internal import (or switch to an already-imported error type if that’s the intended API).
|
|
||
| if tt.funcIgnoreContent != "" { | ||
| err := os.WriteFile( | ||
| filepath.Join(serviceConfig.Path(), ".funcignore"), |
There was a problem hiding this comment.
The production logic reads filepath.Join(serviceConfig.Path(), serviceConfig.Host.IgnoreFile()), but the test hard-codes ".funcignore". To keep the test aligned with the implementation (and avoid breakage if the ignore filename becomes host-dependent), write to serviceConfig.Host.IgnoreFile() here.
Suggested change
| filepath.Join(serviceConfig.Path(), ".funcignore"), | |
| filepath.Join(serviceConfig.Path(), serviceConfig.Host.IgnoreFile()), |
| // resolveFunctionAppRemoteBuild returns the appropriate remote build setting for function apps. | ||
| func resolveFunctionAppRemoteBuild(serviceConfig *ServiceConfig) (remoteBuild bool, err error) { | ||
| switch serviceConfig.Language { | ||
| case ServiceLanguageJavaScript, ServiceLanguageTypeScript: |
There was a problem hiding this comment.
The resolver has explicit TypeScript behavior (ServiceLanguageTypeScript) but the added matrix test only covers JavaScript. Add at least one TypeScript test case (can reuse the same matrix) to ensure the TypeScript path stays correct.
Suggested change
| case ServiceLanguageJavaScript, ServiceLanguageTypeScript: | |
| case ServiceLanguageJavaScript: | |
| fallthrough | |
| case ServiceLanguageTypeScript: |
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
JeffreyCA
approved these changes
Mar 23, 2026
spboyer
requested changes
Mar 24, 2026
Member
spboyer
left a comment
spboyer
left a comment
There was a problem hiding this comment.
Please address the copilot feedback, either comment or commit to address,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, azd defaults
remoteBuild: truefor flex-consumption function apps. This static default causes customer pain when the.funcignorefile contents isn't compatible with the build behavior. Primarily, users scaffolding a function app project usingfunccli are impacted.To address this, we now default the
remoteBuildsetting intelligently based on the contents of the.funcignorefile. WhenremoteBuildis set explicitly, we also validate and fail fast if the.funcignoreis detected to be incompatible (i.e. the presence ofnode_modules).Fixes #6531